Nir Soffer has posted comments on this change. Change subject: vm: Libvirt quering after disk detach operation addition. ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/45138/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2626: try: Line 2627: self._dom.detachDevice(driveXml) Line 2628: deadline = utils.monotonic_time() + \ Line 2629: float(config.get('vars', 'wait_for_detach')) Line 2630: while drive.serial in self._dom.XMLDesc(0): > As replied in patch set #1, we cannot use the apis in this module, these me Then add new api to search for disk in the xml - should be couple of lines using ElementTree api. Line 2631: self.log.debug("Waiting for hotunplug to finish.") Line 2632: time.sleep(1) Line 2633: if utils.monotonic_time() > deadline: Line 2634: return response.error('hotunplugDisk', -- To view, visit https://gerrit.ovirt.org/45138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393ce55dd761ac825cb96bd499976fd74c366b09 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
