Petr Horáček has posted comments on this change. Change subject: netinfo: remove unused and hide private functions ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/45084/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 810: """ Returns tuples of (bridge/network, vlan) connected to nic/bond """ Line 811: return chain(self._getBridgedNetworksAndVlansForIface(iface), Line 812: self._getBridgelessNetworksAndVlansForIface(iface)) Line 813: Line 814: def _getBridgedNetworksAndVlansForIface(self, iface): why dont you rename this to snake_case as well? like getVlanDevice Line 815: """ Returns tuples of (bridge, vlan) connected to nic/bond """ Line 816: for network, netdict in self.networks.iteritems(): Line 817: if netdict['bridged']: Line 818: for interface in netdict['ports']: -- To view, visit https://gerrit.ovirt.org/45084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a93282b95f1d174192274c91c14c98e6f771c17 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
