Saggi Mizrahi has posted comments on this change.

Change subject: Make libvirtvm.py PEP8 compliant
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 269:                         'writeLatency': '0',
Line 270:                         'flushLatency': '0'}
Line 271:             try:
Line 272:                 (dLatency['readLatency'], dLatency['writeLatency'],
Line 273:                 dLatency['flushLatency']) = 
_avgLatencyCalc(sInfo[dName],
Further more it would break "indentation being a multiply of four".
Line 274:                         eInfo[dName])
Line 275:             except (KeyError, TypeError):
Line 276:                 self._log.debug("Disk %s latency not available", 
dName)
Line 277:             else:


--
To view, visit http://gerrit.ovirt.org/7422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to