Adam Litke has posted comments on this change. Change subject: volume: Support older engine or disks with long description ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/45501/1//COMMIT_MSG Commit Message: Line 11: existing disks with long description. For example, copying old disk with Line 12: long description from file to block storage. Line 13: Line 14: The description field has now maximum size; if the size exceeds the Line 15: limit, it is silently truncated when creating any volume type. Please remove 'silently' from this sentence. It had me worried that you weren't logging this event. You are logging it (which is the right thing to do) so it is not _silently_ truncated. Line 16: Line 17: Change-Id: Ie3b1d9da0084aa5db02b29295d4cd0d5d8178ca2 Line 18: Backport-To: 3.6 Line 19: Bug-Url: https://bugzilla.redhat.com/1258097 https://gerrit.ovirt.org/#/c/45501/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 8140 Line 8141 Line 8142 Line 8143 Line 8144 How was 210 calculated? Is it merely BLOCK_SIZE - (the sum of the rest of the fields)? In this case, what happens if we want to add a new field to the metadata? Does it make sense to reserve some unused space? https://gerrit.ovirt.org/#/c/45501/1/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 131: # Line 132: # We use a limit of 210 bytes for the description field, leaving couple Line 133: # of bytes for unexpected future changes. This should good enough for Line 134: # ascii values, but limit non-ascii values, which are encoded by engine Line 135: # using 4 bytes per character. Aha! I appreciate the information here. I suppose if we needed to reclaim space for implementing a future storage feature we could "Upgrade" volume metadata in the future and remove unneeded fields at that time. Line 136: DESCRIPTION_SIZE = 210 Line 137: Line 138: Line 139: def fmt2str(format): -- To view, visit https://gerrit.ovirt.org/45501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b1d9da0084aa5db02b29295d4cd0d5d8178ca2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
