Francesco Romani has posted comments on this change. Change subject: virt: Remove QEMU passthrough hack in ppc64 ......................................................................
Patch Set 14: Code-Review+2 (1 comment) ok, now looks fine to me https://gerrit.ovirt.org/#/c/33871/14/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1599: domxml._appendAgentDevice(self._guestSocketFile.decode('utf-8'), Line 1600: _VMCHANNEL_DEVICE_NAME) Line 1601: domxml._appendAgentDevice(self._qemuguestSocketFile.decode('utf-8'), Line 1602: _QEMU_GA_DEVICE_NAME) Line 1603: spurious, but not worth enough to resubmit (again) Line 1604: domxml.appendInput() Line 1605: Line 1606: if self.arch == caps.Architecture.PPC64: Line 1607: domxml.appendEmulator() -- To view, visit https://gerrit.ovirt.org/33871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d660bf7534203d5d5cdbc318ffd1429a16f954 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
