Nir Soffer has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 11: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/45077/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2609: self._devices[hwclass.DISK].remove(drive) Line 2610: Line 2611: # Find and remove disk device from vm's conf Line 2612: for dev in self.conf['devices'][:]: Line 2613: if (dev['type'] == hwclass.DISK and dev['path'] == drive.path): The parenthesis are not needed now, please use: if dev['type'] == hwclass.DISK and dev['path'] == drive.path: Line 2614: with self._confLock: Line 2615: self.conf['devices'].remove(dev) Line 2616: break Line 2617: -- To view, visit https://gerrit.ovirt.org/45077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
