Freddy Rolland has posted comments on this change. Change subject: hsm: Support checkStatus param in getDeviceList ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/45093/7/client/vdsClient.py File client/vdsClient.py: Line 735: elif len(args) == 1: Line 736: res = self.s.getDeviceList(args[0]) Line 737: else: Line 738: res = self.s.getDeviceList(args[0], utils.tobool(args[1]), Line 739: args[2:]) > guids be be sent before checkStatus - xmlrpc is using positional arguments. Done Line 740: Line 741: if res['status']['code']: Line 742: return res['status']['code'], res['status']['message'] Line 743: pp.pprint(res['devList']) https://gerrit.ovirt.org/#/c/45093/7/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 1029: api = API.Global() Line 1030: return api.getLVMVolumeGroups(storageType) Line 1031: Line 1032: def devicesGetList(self, storageType=None, checkStatus=True, Line 1033: guids=(), options=None): > There is one more isssue - you added the new parameter in a non-backward co Done Line 1034: api = API.Global() Line 1035: res = api.getDeviceList(storageType, checkStatus, guids) Line 1036: return unprotect_passwords(res) Line 1037: https://gerrit.ovirt.org/#/c/45093/7/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1499: # Line 1500: # @storageType: #optional Only return devices of this type Line 1501: # Line 1502: # @checkStatus: #optional Indicates if device status should be checked Line 1503: # (new in version 4.17) > Must be after guids for backward compatibility. Done Line 1504: # Line 1505: # @guids: #optional Only return info on specific list of block device Line 1506: # GUIDs (new in version 4.17) Line 1507: # -- To view, visit https://gerrit.ovirt.org/45093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
