Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Introduce class structure ......................................................................
Patch Set 17: Code-Review-1 (1 comment) Partial review https://gerrit.ovirt.org/#/c/41844/17/vdsm/storage/blockVolume.py File vdsm/storage/blockVolume.py: Line 113: Line 114: class BlockVolume(volume.Volume): Line 115: """ Actually represents a single volume (i.e. part of virtual disk). Line 116: """ Line 117: MetadataClass = BlockVolumeMetadata metadataClass Line 118: Line 119: def __init__(self, repoPath, sdUUID, imgUUID, volUUID): Line 120: md = self.MetadataClass(repoPath, sdUUID, imgUUID, volUUID) Line 121: self.metaoff = None -- To view, visit https://gerrit.ovirt.org/41844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0552bea23b04b9e58e5d2cc7e016103d03194d1a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches