Francesco Romani has posted comments on this change. Change subject: network.api: EL7's dhclient doesn't support -df so stop using it temporarily ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/45713/2/vdsm/network/configurators/dhclient.py File vdsm/network/configurators/dhclient.py: Line 70: Line 71: def start(self, blocking): Line 72: if blocking: Line 73: rc, out, err = self._dhclient() Line 74: return rc, out, err maybe just return self._dhclient() ? Line 75: else: Line 76: t = threading.Thread(target=self._dhclient, name='vdsm-dhclient-%s' Line 77: % self.iface) Line 78: t.daemon = True Line 137: Line 138: Line 139: @memoized Line 140: def supports_duid_file(): Line 141: probe = DhcpClient('-invalid-option') # dhclient doesn't have -h/--help well, if it doesn't support -h/--help, then --help is as good as '-invalid-option', it isn't? :) So what about just using --help ? Line 142: rc, out, err = probe.start(blocking=True) Line 143: if rc: Line 144: for line in err: Line 145: if '-df' in line: -- To view, visit https://gerrit.ovirt.org/45713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia096d42d24b00e7ef075f1a2dde7e3a951c0b81c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
