Dan Kenigsberg has submitted this change and it was merged. Change subject: net: run dhclient in its own process group. ......................................................................
net: run dhclient in its own process group. This is done to prevent systemd from killing supervdsm dhclient child processes during supervdsm stop (or restart). Forking dhclient in its own process group prevents systemd from doing this. Since dhclient is deliberately killed either directly by supervdsm or indirectly by executing ifdown on a device and since executing a process in a different process group is harmless, the separate cgroup is now the default behaviour. This patch also fixes https://bugzilla.redhat.com/1187244 in a less clumsy way than KillMode=process. Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Signed-off-by: Ido Barkan <[email protected]> Bug-Url: https://bugzilla.redhat.com/1228322 Reviewed-on: https://gerrit.ovirt.org/43005 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/43853 --- M init/systemd/vdsm-network.service.in M vdsm/network/configurators/dhclient.py M vdsm/network/configurators/ifcfg.py 3 files changed, 24 insertions(+), 7 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
