Liron Aravot has posted comments on this change. Change subject: sp: deactivateSd - remove domain from pending for upgrade list ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45773/1/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 1094 Line 1095 Line 1096 Line 1097 Line 1098 > Ok, since in deactivateStoargeDomain flow we are holding both the pool and we need to have a mutual lock between the upgrade and the metadata operations, that was handled by the lock on my change here. but its actually better to add the lock to the upgrade rather then to this verb (as it'll fix it for other scenarios as well..but has a wider scope). -- To view, visit https://gerrit.ovirt.org/45773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451b348b8837dd83d95aea2be4a4536b33cdd99 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
