Nir Soffer has posted comments on this change. Change subject: jsonrpc: more meaningful name of address param ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45839/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 244: "]") Line 245: Line 246: Line 247: class _JsonRpcServeRequestContext(object): Line 248: def __init__(self, client, server_address): This is always the server address - right? (In a previous patch you explained that we reuse this code in both client and server) Line 249: self._requests = [] Line 250: self._client = client Line 251: self._server_address = server_address Line 252: self._counter = 0 -- To view, visit https://gerrit.ovirt.org/45839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1aaba81cadd84e6264e7f59e552879f26d74cbc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
