Yaniv Bronhaim has posted comments on this change. Change subject: safelease: Fix wrong parameter name ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/45960/2/vdsm/storage/protect/spmstop.sh File vdsm/storage/protect/spmstop.sh: Line 28: if [ -n "$1" ]; then Line 29: echo $1 Line 30: fi Line 31: echo "usage: $0 { sdUUID }" Line 32: echo " sdUUID - storage domain uuid" probably it was aligned for a reason.. but im sure you checked that Line 33: exit 1 Line 34: } Line 35: Line 36: function debug() { -- To view, visit https://gerrit.ovirt.org/45960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a0a7f6f60fae8d7833a679069f6de865d82d79b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
