Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: only determine and write HWADDR in removeNic if enabled ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/45983/2/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 644: mtu = int(mtu) Line 645: return ipv4, ipv6, mtu Line 646: Line 647: @staticmethod Line 648: def _hwaddr_from_ifcfg_or_system(nic, ifcfg): why do you need this generalization? I'm not sure we'd want to swallow any exception on the addNic flow. Line 649: if not _hwaddr_required(): Line 650: return [] Line 651: try: Line 652: with open(ifcfg) as ifcfg_file: -- To view, visit https://gerrit.ovirt.org/45983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb4e7cdae83998b4102e79b7cb548ed95f672433 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
