Dan Kenigsberg has posted comments on this change. Change subject: configurator doesn't load pyc files under configurators folder ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/45846/6/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 60: ) Line 61: Line 62: Line 63: _CONFIGURATORS = {} Line 64: configurators_path = os.path.join(os.path.abspath(configurators.__path__[0])) this should be a _PRIVATE_CONSTANT, no? Line 65: for module in _listmodules(configurators_path): Line 66: _CONFIGURATORS[module] = _import_module(configurators, module) Line 67: if not hasattr(_CONFIGURATORS[module], 'name'): Line 68: setattr(_CONFIGURATORS[module], 'name', module) -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
