Dan Kenigsberg has submitted this change and it was merged. Change subject: configurator doesn't load pyc files under configurators folder ......................................................................
configurator doesn't load pyc files under configurators folder configurator loads dynamically modules from configurators folder. It searches for py files only. In ovirt-node installation we install only pyc files and this caused us to miss all configurators modules in ovirt-node installation. The listmodules function now returns a set to avoid duplicate module names. Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1259247 Signed-off-by: Yaniv Bronhaim <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45846 Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Oved Ourfali <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <[email protected]> --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 27 insertions(+), 13 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia529de0069e2f4ec168a4b9df82ba62c56d66730 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
