Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: Move clusterLock into Manifest ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/43549/12/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 117: log.debug("Setting permissions for domain %s", domain.sdUUID) Line 118: domain.setMetadataPermissions() Line 119: Line 120: log.debug("Initializing the new cluster lock for domain %s", domain.sdUUID) Line 121: newClusterLock = domain._manifest._makeDomainLock(targetVersion) > Because we removed it. This is the only consumer of that logic so I decide Please keep the domain._makeClusterLock() for now, even if this is the only caller. Line 122: newClusterLock.initLock() Line 123: Line 124: log.debug("Acquiring the host id %s for domain %s", hostId, domain.sdUUID) Line 125: newClusterLock.acquireHostId(hostId, async=False) -- To view, visit https://gerrit.ovirt.org/43549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c019a7fed6ba793d2b3a2459af221b1abbff2a3 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
