Marcin Mirecki has posted comments on this change. Change subject: network: add ifcfg write hook ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/44552/5/vdsm/hooks.py File vdsm/hooks.py: Line 395: return _runHooksDir(hook_dict, 'before_ifcfg_write', raiseError=False, Line 396: hookType=_JSON_HOOK) Line 397: Line 398: Line 399: def after_ifcfg_write(hook_dict): > Please drop this hookpoint - unless you provide a use case for it. I gave it a little thought and I think it might be useful. Some use cases for this could be triggering updates is security policies (informing about a new ip in the network) or triggering updates in dns's. This would be nice to do only after the ifcfg file is successfully updated. Line 400: return _runHooksDir(hook_dict, 'after_ifcfg_write', raiseError=False, Line 401: hookType=_JSON_HOOK) Line 402: Line 403: -- To view, visit https://gerrit.ovirt.org/44552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
