Dan Kenigsberg has submitted this change and it was merged. Change subject: lvm: Check if device in VG before extend ......................................................................
lvm: Check if device in VG before extend Before extending a VG, VDSM needs to check that none of the additional devices are not already part of the VG. Without this protection, LVM will create a new PV with the same device. After extending VG, its metadata will updated with new PV. As a result, the VG will be partial. pvs output after creating new PV with same device: # pvs WARNING: Device for PV 2fDjgH-TeKA-1Vy2-NMMv-GB9n-op0w-g2Nyrd not found or rejected by a filter. PV /dev/mapper/360014054bf6dd7d14fd40c9ac3b5dbe8 unknown device Change-Id: Ifec2503094d6a0ecdd32e5e62f9c01a1469145f3 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1261531 Signed-off-by: Fred Rolland <froll...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/45946 Continuous-Integration: Jenkins CI Reviewed-by: Allon Mureinik <amure...@redhat.com> Reviewed-by: Nir Soffer <nsof...@redhat.com> --- M vdsm/storage/lvm.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/45946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifec2503094d6a0ecdd32e5e62f9c01a1469145f3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches