Dan Kenigsberg has posted comments on this change. Change subject: virt: vm with port mirroring stuck in down state ......................................................................
Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/45344/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3691: if hasattr(nic, 'portMirroring'): Line 3692: for network in nic.portMirroring[:]: Line 3693: supervdsm.getProxy().unsetPortMirroring(network, Line 3694: nic.name) Line 3695: nic.portMirroring.remove(network) > This actually helps if port mirroring on the nics has been unset before the https://bugzilla.redhat.com/show_bug.cgi?id=1011887 has some ideas regarding the needed refactoring Line 3696: Line 3697: self.log.info('Release VM resources') Line 3698: self.lastStatus = vmstatus.POWERING_DOWN Line 3699: # Terminate the VM's creation thread. -- To view, visit https://gerrit.ovirt.org/45344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43369f584f696f1387685ec8f4fc4b6f58d98a6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
