Piotr Kliczewski has posted comments on this change.

Change subject: Limit sleep_millisecs to minimum 10
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/46006/2/vdsm/mom.d/03-ksm.policy
File vdsm/mom.d/03-ksm.policy:

Line 46:     (Host.Control "ksm_run" 0)
Line 47:     {        # else
Line 48:         (Host.Control "ksm_run" 1)
Line 49:         (Host.Control "ksm_sleep_millisecs"
Line 50:             (max 10 (/ (* ksm_sleep_ms_baseline 16777216)
In your commit message I can see:

"10 should be the minimum value for sleep_millisec"

Whereas here I can see "max". Is that intentional?
Line 51:                        Host.mem_available)))
Line 52:        (if (< (Host.StatAvg "mem_free") ksm_pressure_threshold)
Line 53:             (change_npages ksm_pages_boost)
Line 54:            (change_npages ksm_pages_decay))


-- 
To view, visit https://gerrit.ovirt.org/46006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7412ca576089f1dae2441ec39f72e7a94b3c8fc9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to