Michal Skrivanek has posted comments on this change. Change subject: vm: graphics: fix settings after restore ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/44842/8/vdsm/virt/vmdevices/graphics.py File vdsm/virt/vmdevices/graphics.py: Line 137: if not utils.tobool(self.specParams.get('disableTicketing', False)): Line 138: attrs['passwd'] = '*****' Line 139: attrs['passwdValidTo'] = '1970-01-01T00:00:01' Line 140: Line 141: def setupSpicePassword(self, domXML): > This is very sneaky and evil without at least a docstring. The behavior is we only have 2 at most... Line 142: if self.device == 'spice': Line 143: domObj = etree.fromstring(domXML) Line 144: devices = domObj.findall('devices') Line 145: -- To view, visit https://gerrit.ovirt.org/44842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f11e2d87cc715c77d305c005c1cd7f502d506d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
