Dan Kenigsberg has submitted this change and it was merged. Change subject: StorageDomainManifest: Move acquireVolumeMetadataSlot ......................................................................
StorageDomainManifest: Move acquireVolumeMetadataSlot Moving acquireVolumeMetadataSlot into the manifest breaks volumeTests which depended on mocking StorageDomain objects. Since we already have the manifest_tests infrastructure, it's better to move the test cases implemented in volumeTests into manifest_tests and use a real BlockStorageDomainManifest for testing. In order to do this we need to add an addtag utility method to our FakeLVM class. Change-Id: I690ed4151428b22774415f38b350676391ccca46 Signed-off-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45389 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> --- M tests/Makefile.am M tests/manifest_tests.py M tests/sdm_indirection_tests.py M tests/storagefakelib.py D tests/volumeTests.py M vdsm/storage/blockSD.py 6 files changed, 138 insertions(+), 152 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690ed4151428b22774415f38b350676391ccca46 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
