Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: check whether the connection is still open before processing ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42920/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 507: Line 508: try: Line 509: if ctx.connection.is_closed(): Line 510: self.log.warning("Ignoring message connection already closed") Line 511: return > so why not to do it as first thing when getting into _serveRequest - or eve Let me explore where it make sense to move it. Line 512: params = req.params Line 513: server_address = ctx.connection.get_local_address() Line 514: self._bridge.register_server_address(server_address) Line 515: if isinstance(req.params, list): -- To view, visit https://gerrit.ovirt.org/42920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53c175882576eded3d4ad1c952148879efe2075e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
