Francesco Romani has posted comments on this change. Change subject: host stats: Add onlineCpus to vdsStats ......................................................................
Patch Set 2: (2 comments) Draft -> no score I'm fine with the concept, but we should polish the Engine interface. Does Engine use this information? Also, please make sure to update vdsm/rpc/vdsmapi-schema.json https://gerrit.ovirt.org/#/c/46270/2/vdsm/API.py File vdsm/API.py: Line 1366: Line 1367: for var in decStats: Line 1368: stats[var] = utils.convertToStr(decStats[var]) Line 1369: Line 1370: stats['onlineCpus'] = ','.join(caps.getOnlineCpus()) this should be part of host stats Line 1371: stats['memAvailable'] = self._memAvailable() / Mbytes Line 1372: stats['memCommitted'] = self._memCommitted() / Mbytes Line 1373: stats['memFree'] = self._memFree() / Mbytes Line 1374: stats['swapTotal'], stats['swapFree'] = _readSwapTotalFree() https://gerrit.ovirt.org/#/c/46270/2/vdsm/caps.py File vdsm/caps.py: Line 211: cpu_map = [] Line 212: for index, online in enumerate(cpu_register): Line 213: if online: Line 214: cpu_map.append(index) Line 215: return cpu_map this doesn't belong here, it is more akin host statistics Line 216: Line 217: Line 218: @utils.memoized Line 219: def _getCapsXMLStr(): -- To view, visit https://gerrit.ovirt.org/46270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
