Francesco Romani has submitted this change and it was merged. Change subject: sp: startSpm - clusterlock inquire leads to failure ......................................................................
sp: startSpm - clusterlock inquire leads to failure Currently startSpm() is responsible for the pool upgrade, it attempts to upgrade the pool domains to the desired version. During the execution of startSpm() we attempt to retrieve the current spm status in order to compare it with the engine sent parameters - and in case of difference we log the info to the user. When a DC upgrade is performed when the DC is down from a version that uses V1 as the domains version to a version that uses the StoragePoolMemoryBackend we'll encounter a problem - because the StoragePoolMemoryBackend uses the information from the clusterlock only and the current clusterlock that is used on the domain might not support inquiring (safelease for example) which will cause it to throw InquireNotSupportError. As we use the inquired information just to display a warning, in case of a clusterlock that doesn't support inquiring we should just log it to the user and continue with starting the spm. Change-Id: I082dc83ea410768db3819e7259089c20c2614b07 Bug-Url: https://bugzilla.redhat.com/1242092 Signed-off-by: Liron Aravot <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45966 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Francesco Romani <[email protected]> --- M vdsm/storage/sp.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/45966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I082dc83ea410768db3819e7259089c20c2614b07 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
