Yaniv Bronhaim has submitted this change and it was merged. Change subject: ifcfg: only determine and write HWADDR in removeNic if enabled ......................................................................
ifcfg: only determine and write HWADDR in removeNic if enabled Writing of HWADDR has been deprecated for long now but for compatibility with pre-1.0 NetworkManager (that matches on HWADDR in order to accept NM_CONTROLLED=no) we shall still write it if requested with hwaddr_in_ifcfg=always in vdsm.conf. This patch makes removeNic follow suit -- addNic was alone in respecting the condition. For more information refer to http://gerrit.ovirt.org/22288 and https://bugzilla.redhat.com/1044060 Change-Id: Ieb4e7cdae83998b4102e79b7cb548ed95f672433 Bug-Url: https://bugzilla.redhat.com/1256252 Signed-off-by: Ondřej Svoboda <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45983 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46281 Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/network/configurators/ifcfg.py 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Ondřej Svoboda: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4e7cdae83998b4102e79b7cb548ed95f672433 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
