Nir Soffer has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46269/4//COMMIT_MSG Commit Message: Line 12: When vdsm is already running, it is enough to do something like Line 13: Line 14: echo 0 > /sys/devices/system/cpu/cpu2/online Line 15: Line 16: to break getVdsStats. To make your change more clear, please show a fraction of the stats vdsm returns after your patch. Also describe how offline cpus are handled - both those that were offline where vdsm started, and those that became offline while vdsm was running. And what about cpu that was offline when vdsm started, and became online while vdsm was running? Line 17: Line 18: Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
