Nir Soffer has uploaded a new change for review.

Change subject: tests: Fix unmount in mkimage tests
......................................................................

tests: Fix unmount in mkimage tests

These tests seem to fail too much lately. Inspecting the code reveal
that we use freeloop=True in mkimage, but do not use this flag in the
tests. This may lead to consuming of all available loop devices, which
may explain the mount failures we get on the CI slaves.

Change-Id: If68a378133757f86b534f65808b2212828d97228
Signed-off-by: Nir Soffer <[email protected]>
---
M tests/mkimageTests.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/46336/1

diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py
index 4a137c7..b99dd08 100644
--- a/tests/mkimageTests.py
+++ b/tests/mkimageTests.py
@@ -173,7 +173,7 @@
             self._check_content(checkPerms=False)
             self._check_label(floppy, label)
         finally:
-            m.umount(force=True)
+            m.umount(force=True, freeloop=True)
             os.unlink(floppy)
 
     @permutations([[None], ['fslabel']])
@@ -203,7 +203,7 @@
                                      (stat.S_IWOTH, False),
                                      (stat.S_IXOTH, False)))
         finally:
-            m.umount(force=True)
+            m.umount(force=True, freeloop=True)
             os.unlink(iso_img)
 
     def test_removeFs(self):


-- 
To view, visit https://gerrit.ovirt.org/46336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to