Petr Horáček has posted comments on this change. Change subject: tests: Abuse permuations to run flaky tests many times ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/46337/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-09-18 03:47:20 +0300 Line 4: Commit: Nir Soffer <[email protected]> Line 5: CommitDate: 2015-09-18 04:07:31 +0300 Line 6: Line 7: tests: Abuse permuations to run flaky tests many times permutations ^ Line 8: Line 9: Change-Id: I066419fb7e06abfc5b8af1206f01e3e87fa80960 https://gerrit.ovirt.org/#/c/46337/3/tests/mkimageTests.py File tests/mkimageTests.py: Line 158: mkimage._decodeFilesIntoDir(self.files, self.workdir) Line 159: self._check_content() Line 160: Line 161: @ValidateRunningAsRoot Line 162: @permutations([["label-%02d" % i] for i in range(100)]) We dropped label=None, should not we keep it? How much time it takes to run it so many times? Line 163: def test_mkFloppyFs(self, label): Line 164: """ Line 165: Tests mkimage.mkFloppyFs creating an image and checking its content. Line 166: Requires root permissions for writing into the floppy image. -- To view, visit https://gerrit.ovirt.org/46337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I066419fb7e06abfc5b8af1206f01e3e87fa80960 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
