Martin Polednik has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/42736/10/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 393: elif feature[0] == '-': Line 394: featureAttrs['policy'] = 'disable' Line 395: cpu.appendChildWithArgs('feature', **featureAttrs) Line 396: elif self.arch in caps.Architecture.POWER: Line 397: features = self.conf.get('cpuType', 'POWER8').split(',') > which are the possible values here? for ppc platform? from qemu/libvirt perspective it's POWER6, POWER7, POWER8; but for us only POWER8 currently Line 398: model = features[0] Line 399: cpu.appendChildWithArgs('model', text=model) Line 400: Line 401: if ('smpCoresPerSocket' in self.conf or -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
