Dan Kenigsberg has posted comments on this change. Change subject: multipath: Fix multipath.conf selinux labels ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46398/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 120: delete=False) as f: Line 121: try: Line 122: f.write(_CONF_DATA) Line 123: f.flush() Line 124: selinux.restorecon(f.name) this explodes if selinux is disabled, for some sad reason. Please condition with if selinux.is_selinux_enabled(): Line 125: os.chmod(f.name, 0o644) Line 126: os.rename(f.name, _CONF_FILE) Line 127: except: Line 128: os.unlink(f.name) -- To view, visit https://gerrit.ovirt.org/46398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0aebae46f30abf908a8f48c4f1f2257394fe616 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
