Ido Barkan has posted comments on this change. Change subject: caps: fix unpacking of list ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46321/1/vdsm/caps.py File vdsm/caps.py: Line 97: host_ports = [port for port in attrs['ports'] if Line 98: not port.startswith('vnet')] Line 99: if not host_ports: # Port-less bridge Line 100: continue Line 101: iface = host_ports[0] How did this happen? Can you reproduce reliably? There shouldn't be in oVirt a bridge with more then one 'non-vnet' ports. This is why this strict unpacking was there. I agree that the failure us a bit misleading, but I think we should at least shout in the logs when this is happening. Line 102: if iface in caps['vlans']: Line 103: vlan_id = caps['vlans'][iface]['vlanid'] Line 104: iface = caps['vlans'][iface]['iface'] Line 105: iface_qdiscs = qdiscs.get(iface) -- To view, visit https://gerrit.ovirt.org/46321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20d4b8b6e3147a29aebcbc7a68b9c92d23aa4307 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
