Nir Soffer has posted comments on this change. Change subject: multipath: Write multipath.conf atomically ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/44869/6/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 79: # "defaults" section), or to devices defined in the "devices" section. Line 80: # Note: This is not available yet on Fedora 21. For more info see Line 81: # https://bugzilla.redhat.com/1253799 Line 82: all_devs yes Line 83: no_path_retry fail > I thought this parameter should be getting numeric values. See https://acce This parameter has too special values, "fail" and "queue". Both are documented in the manual you mention. From the manual: - A numeric value for this attribute specifies the number of times the system should attempt to use a failed path before disabling queueing. - A value of fail indicates immediate failure, without queueing. - A value of queue indicates that queueing should not stop until the path is fixed. - The default value is 0. This code is supporting only el7 now, so the correct manual is https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/DM_Multipath/config_file_defaults.html Line 84: } Line 85: } Line 86: Line 87: # Enable when this section is available on all supported platforms. -- To view, visit https://gerrit.ovirt.org/44869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850d621b7cb09f2732b8b3eb2cb2897e87547ddb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fdeut...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
