Arik Hadas has posted comments on this change. Change subject: storage: Initial size for thin provisioning disk ......................................................................
Patch Set 3: Code-Review+1 (2 comments) minor comments inside. very important patch for import VMs using virt-v2v - thanks https://gerrit.ovirt.org/#/c/46417/3/client/vdsClient.py File client/vdsClient.py: Line 1091: else: Line 1092: image = self.s.createVolume(sdUUID, spUUID, imgUUID, size, Line 1093: volFormat, preallocate, Line 1094: diskType, newVol, descr, Line 1095: srcImgUUID, srcVolUUID) lines 1086, 1091-1095 are redundant Line 1096: if image['status']['code']: Line 1097: return image['status']['code'], image['status']['message'] Line 1098: return 0, image['uuid'] Line 1099: https://gerrit.ovirt.org/#/c/46417/3/vdsm/storage/fileVolume.py File vdsm/storage/fileVolume.py: Line 106: """ Line 107: if initialSize: Line 108: cls.log.info("Request to create %s volume %s with initial size" Line 109: " = %s sectors. Initial size is not supported in " Line 110: "File Volumes", volume.type2name(volFormat), Although the log level is info which indicates that it is not an error, I would suggest to add something like ".. - ignoring it" Line 111: volPath, initialSize) Line 112: Line 113: sizeBytes = size * BLOCK_SIZE Line 114: truncSize = sizeBytes if volFormat == volume.RAW_FORMAT else 0 -- To view, visit https://gerrit.ovirt.org/46417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf5f142541bf0b311a77a0544a1c4ffb689a9fde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
