Dan Kenigsberg has posted comments on this change. Change subject: network: add ifcfg write hook ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46372/1/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 946: Line 947: return ifcfgs Line 948: Line 949: Line 950: def _build_ifcfg_write_hook_dict(name, ifcfg_file, conf): > I would just inline this function, as it is a short dict literal. calling i ok... I don't really mind. Line 951: hook_dict = {'name': name, Line 952: 'ifcfg_file': ifcfg_file, Line 953: 'config': conf} -- To view, visit https://gerrit.ovirt.org/46372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
