Francesco Romani has submitted this change and it was merged. Change subject: safelease: Unbreak safelease on systemd ......................................................................
safelease: Unbreak safelease on systemd spmprotect.sh depends on Vdsm pid file for fencing Vdsm when the SPM lease cannot be renewed. However, on systemd, we do not create Vdsm pid file. When spmprotect tries to fence Vdsm it fails and reboots the host, killing all running vms. This issue effects only v1 storage domains, typically old systems using dc compatibility version 3.0. Now we pass vdsm pid to spmprotect.sh helper script via command line argument, restoring safelease operation. Adding another argument to a script with 9 arguments is ugly, but I don't want to make risky changes to this delicate and critical code. Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Bug-Url: https://bugzilla.redhat.com/1222564 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45963 Continuous-Integration: Jenkins CI Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Adam Litke <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46331 Reviewed-by: Francesco Romani <[email protected]> --- M vdsm/storage/clusterlock.py M vdsm/storage/protect/spmprotect.sh.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
