Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: graphics: fix settings after restore ......................................................................
vm: graphics: fix settings after restore When restoring a VM from a memory snapshot, if we don't reset the some details of the SPICE configuration will be lost, and the restored VM will behave erratically. This behaviour is easily reproduced by: a. boot a VM with SPICE graphic device b. do a snapshot, make sure to check 'snapshot memory' c. preview the snapshot d. run the VM e. check the VM parameters (e.g. qemu) The automatic restore using virDomainRestoreFlags() uses the wrong configuration settings. To fix this, we need to amend the VM Domain XML, tuning the configuration the same way we do for VM startup. Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1260177 Change-Id: Ic9f11e2d87cc715c77d305c005c1cd7f502d506d Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/44842 Continuous-Integration: Jenkins CI Reviewed-by: Martin Polednik <mpoled...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/devices/data/Makefile.am A tests/devices/data/vm_restore_spice_after.xml A tests/devices/data/vm_restore_spice_before.xml M tests/vmTests.py M vdsm/virt/vm.py M vdsm/virt/vmdevices/graphics.py 6 files changed, 363 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44842 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9f11e2d87cc715c77d305c005c1cd7f502d506d Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
