Adam Litke has posted comments on this change. Change subject: tests: Generalize sdm_indirection_tests ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46259/2/tests/sdm_indirection_tests.py File tests/sdm_indirection_tests.py: Line 380: @expandPermutations Line 381: class BlockDomainTests(DomainTestMixin, VdsmTestCase): Line 382: Line 383: def setUp(self): Line 384: self.source_inst = FakeBlockStorageDomain() > Now that we have a checker, why do we need to use abstract name when we are Done Line 385: self.checker = RedirectionChecker(self.source_inst, '_manifest') Line 386: Line 387: def test_block_properties(self): Line 388: self.assertEqual(512, self.source_inst.logBlkSize) -- To view, visit https://gerrit.ovirt.org/46259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb68cb27d4e36c22f74a1cc445f38bea4d0ce4da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
