Francesco Romani has submitted this change and it was merged. Change subject: blockVolume: Fail if metadata overflows ......................................................................
blockVolume: Fail if metadata overflows We used to truncate silently volume metadata if it was too long, storing invalid metadata that would cause various failures later. The metadata can overflow if volume description, or since ovirt 3.5, volume alias is too long. Both alias and description are stored now in json format in the DESCRIPTION field. Now we raise MetadataOverflowError, the same error raised when storage domain metadata overflow. This will fail the volume creation. Change-Id: I9ac286c68307e4a1925b9430a0b3b9909cdd682a Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1258097 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/45472 Reviewed-by: Idan Shaby <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Maor Lipchuk <[email protected]> Reviewed-by: Freddy Rolland <[email protected]> Reviewed-by: Tal Nisan <[email protected]> Reviewed-by: Adam Litke <[email protected]> Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/46329 Reviewed-by: Francesco Romani <[email protected]> --- M vdsm/storage/blockVolume.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac286c68307e4a1925b9430a0b3b9909cdd682a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
