Petr Horáček has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46448/2/tests/nettestlib.py File tests/nettestlib.py: Line 261: Line 262: def start(self): Line 263: cmd = [EXT_IPERF3, '--server', '--bind', self._bind_to, '--daemon'] Line 264: if self._net_ns is not None: Line 265: cmd = ['ip', 'netns', 'exec', self._net_ns] + cmd why not use ipwrapper.netns_exec() instead? Line 266: rc, out, err = execCmd(cmd) Line 267: return rc Line 268: Line 269: -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
