Ayal Baron has posted comments on this change.
Change subject: Related to BZ#845020 - Diffferentiate bad specification from
not found.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-08-21 11:54:07 +0300
Line 4: Commit: Eduardo Warszawski <ewars...@redhat.com>
Line 5: CommitDate: 2012-08-21 11:54:07 +0300
Line 6:
Line 7: Related to BZ#845020 - Diffferentiate bad specification from not found.
s/fff/ff/
bad specification of what? no point for bug title here, rather put the crux of
the issue.
Line 8:
Line 9: Already agreed that _devices should be a dict instead a list.
Line 10:
Line 11: Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Line 5: CommitDate: 2012-08-21 11:54:07 +0300
Line 6:
Line 7: Related to BZ#845020 - Diffferentiate bad specification from not found.
Line 8:
Line 9: Already agreed that _devices should be a dict instead a list.
agreed with whom? why?
commit message should not contain 'conversations' just an explanation of 'what'
the patch does and 'why'
Line 10:
Line 11: Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
....................................................
File vdsm/libvirtvm.py
Line 1628: device.volumeID) == tgetDrv):
Line 1629: return device
Line 1630: else:
Line 1631: self.log.warning("drive dom: %s, img: %s, vol: %s is
not in"
Line 1632: "vm: %s _devices",
drive["domainID"],
trailing space
Line 1633: drive["imageID"],
drive["volumeID"], self.id)
Line 1634: return None
Line 1635:
Line 1636: elif drive.has_key("GUID"):
--
To view, visit http://gerrit.ovirt.org/7366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5cffdae26cde88a948211d8577370965ecd2d36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
