Zhou Zheng Sheng has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_cli/vdsClient.py
Line 1372: return 0, ''
Line 1373:
Line 1374: def do_getVmsInfo(self, args):
Line 1375: spUUID = args[0]
Line 1376: if len(args) >= 2:
From this code we can see, if vm id list is given, then the sdUUID must be
given as well. If sdUUID is not given, then vm id list must not be given too.
Line 1377: sdUUID = args[1]
Line 1378: else:
Line 1379: sdUUID = BLANK_UUID
Line 1380: if len(args) >= 3:
Line 2220: 'Send a string containing monitor command
to the '
Line 2221: 'desktop'
Line 2222: )),
Line 2223: 'getVmsInfo': (serv.do_getVmsInfo,
Line 2224: ('<spUUID> [sdUUID] [vmList](vmId1,vmId2,...)',
After reading the implementation of do_getVmsInfo, I think the command format
is as follow.
<spUUID> [<sdUUID> [vmList](vmId1,vmId2,...)]
Due to the implementation limit, we can not ignore the second parameter and
just pass the third parameter.
Line 2225: 'Return info of VMs from the pool or a backup
domain '
Line 2226: 'if it\'s sdUUID given. If vmList also given,
only get '
Line 2227: 'info for these VMs.'
Line 2228: )),
--
To view, visit http://gerrit.ovirt.org/7560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I152f28dea29f6ac6bb61c0597dbd3b596646c569
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhu Bo <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
