Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: always hold confLock when updating pauseCode ......................................................................
vm: always hold confLock when updating pauseCode An update of pauseCode can create a new field in Vm.conf. If a client calls the getVMList() API, or for any other API which needs to loop over all the VM conf, we can end up with RuntimeError: dictionary changed size during iteration This patch make sure that when we update Vm.conf with pauseCode-related data, we always have Vm.confLock held. Change-Id: Ie84e2442165fb524f2433fab7faa3b049b340038 Bug-Url: https://bugzilla.redhat.com/1261918 Backport-To: 3.6 Backport-To: 3.5 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46005 Continuous-Integration: Jenkins CI Reviewed-by: Michal Skrivanek <[email protected]> Reviewed-by: Martin Polednik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84e2442165fb524f2433fab7faa3b049b340038 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
