Francesco Romani has posted comments on this change. Change subject: virt: add VmTracker to track domain traffic ......................................................................
Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/44543/16/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 128: self._busy = set() Line 129: Line 130: @property Line 131: def busy(self): Line 132: return self._busy > Doesn't make sense as a part of this patch. Right this is a relic. Removed. Line 133: Line 134: def reserve_available(self, vm_ids): Line 135: """ Line 136: Expects vm_ids to be a set of vm.id Line 133: Line 134: def reserve_available(self, vm_ids): Line 135: """ Line 136: Expects vm_ids to be a set of vm.id Line 137: Return subset of vm_ids that it is free to run. > that is free to run (drop 'it') or if you can figure out more pleasant phra Done Line 138: """ Line 139: with self._lock: Line 140: # we need lock to guard against concurrent Line 141: # invocations of this method. Line 139: with self._lock: Line 140: # we need lock to guard against concurrent Line 141: # invocations of this method. Line 142: avail = vm_ids - self._busy Line 143: self._busy.update(avail) > self._busy |= vm_ids ? nicer, will use. Line 144: return avail Line 145: Line 146: def release(self, vm_id): Line 147: self._busy.remove(vm_id) -- To view, visit https://gerrit.ovirt.org/44543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab735193ea7b2e177e146099843cc31706379e68 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
