Francesco Romani has uploaded a new change for review. Change subject: pyflakes: tests: unbreak pyflakes test ......................................................................
pyflakes: tests: unbreak pyflakes test A stale socket import break pyflakes 0.8.1: ./tests/integration/jsonRpcHelper.py:22: 'socket' imported but unused ./tests/integration/jsonRpcHelper.py:153: redefinition of unused 'socket' from line 22 ./tests/integration/jsonRpcHelper.py:181: redefinition of unused 'socket' from line 22 This patch fixes that removing the unused import. After that, the "socket" name becomes free to go again. "socket" is probably not the best name around, but IMO is good enough in this context, so I didn't change it. Change-Id: Id2249ede768e1e4e1e07a38783459eed411aa5bd Signed-off-by: Francesco Romani <[email protected]> --- M tests/integration/jsonRpcHelper.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/46800/1 diff --git a/tests/integration/jsonRpcHelper.py b/tests/integration/jsonRpcHelper.py index 38c4c73..5f538b9 100644 --- a/tests/integration/jsonRpcHelper.py +++ b/tests/integration/jsonRpcHelper.py @@ -19,7 +19,6 @@ # import httplib import logging -import socket import threading from collections import defaultdict -- To view, visit https://gerrit.ovirt.org/46800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2249ede768e1e4e1e07a38783459eed411aa5bd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
