Francesco Romani has posted comments on this change. Change subject: caps: add fake emulated machines ......................................................................
Patch Set 1: Code-Review+1 (2 comments) I'd really like to go in the direction to make all fake_* stuff an hook, but probably not feasible right now. Partial ACK. https://gerrit.ovirt.org/#/c/46852/1/vdsm/caps.py File vdsm/caps.py: Line 381: return AutoNumaBalancingStatus.UNKNOWN Line 382: Line 383: Line 384: def _get_fake_emulated_machines(): Line 385: ppc64le_machines = ['pseries', 'pseries-rhel7.2.0'] minor: let's reformat this like ppc64le_machines = [ 'pseries', 'pseries-rhel7.2.0' ] Line 386: x86_64_machines = ['pc-i440fx-rhel7.1.0', Line 387: 'rhel6.3.0', Line 388: 'pc-q35-rhel7.2.0', Line 389: 'pc-i440fx-rhel7.0.0', Line 383: Line 384: def _get_fake_emulated_machines(): Line 385: ppc64le_machines = ['pseries', 'pseries-rhel7.2.0'] Line 386: x86_64_machines = ['pc-i440fx-rhel7.1.0', Line 387: 'rhel6.3.0', same as above Line 388: 'pc-q35-rhel7.2.0', Line 389: 'pc-i440fx-rhel7.0.0', Line 390: 'rhel6.1.0', Line 391: 'rhel6.6.0', -- To view, visit https://gerrit.ovirt.org/46852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707515225b9034adda1770870d9a6939ecca9e5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
