Martin Polednik has posted comments on this change. Change subject: vdsm: isolate cpu info and architecture in a new module ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/46912/2/tests/nettestlib.py File tests/nettestlib.py: Line 101: _IFF_NO_PI = 0x1000 Line 102: if cpuinfo.arch() == cpuinfo.Architecture.X86_64: Line 103: _TUNSETIFF = 0x400454ca Line 104: elif cpuinfo.arch() in 'ppc64': Line 105: _TUNSETIFF = 0x800454ca !remindme of code smell Line 106: else: Line 107: raise cpuinfo.UnsupportedArchitecture Line 108: Line 109: _deviceListener = None https://gerrit.ovirt.org/#/c/46912/2/vdsm/caps.py File vdsm/caps.py: Line 390: arch = 'x86' Line 391: Line 392: # Same goes for ppc64le Line 393: if cpuinfo.arch() in cpuinfo.Architecture.POWER: Line 394: arch = 'ppc64' Might make sense to move the non-standard mappings to cpuinfo. Line 395: Line 396: architectureElement = None Line 397: Line 398: architectureElements = cpu_map.findall('arch') -- To view, visit https://gerrit.ovirt.org/46912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
