Francesco Romani has posted comments on this change. Change subject: sampling: add 'ncpus' property to HostSample ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/42035/13/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 555: self._ncpus = max(os.sysconf('SC_NPROCESSORS_ONLN'), 1) > I think ncpus can be moved to hoststats.py and we can look it up every time nice idea, but also change in behaviour. Which is probably a good thing, because the old one doesn't consider the cpu offlining/onlining. -- To view, visit https://gerrit.ovirt.org/42035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e7d549b7772e3f38eec2dd9b91bbc6416b549bf Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
