Francesco Romani has posted comments on this change. Change subject: test: moving getInstance to its class ......................................................................
Patch Set 2: (1 comment) the jsonRpcHelper change looks a bit funny, but I don't really mind. https://gerrit.ovirt.org/#/c/46941/2/tests/integration/jsonRpcHelper.py File tests/integration/jsonRpcHelper.py: Line 62: """ Line 63: This method is used to mock real ClientIf getInstance. Line 64: It returns new FakeClientIf every time. Line 65: """ Line 66: def getInstance(self): docstring is supposed to be here, but I don't really mind :) Line 67: return FakeClientIf() Line 68: Line 69: @property Line 70: def ready(self): -- To view, visit https://gerrit.ovirt.org/46941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadc44aef17d1ebcf8b6b7b63fce3fa8d34b4c0a3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
